Skip to content

Add visit for Ellipsis . - #2021

Merged
certik merged 1 commit into
lcompilers:mainfrom
faze-geek:Ellipsis
Jun 25, 2023
Merged

certik merged 1 commit into
lcompilers:mainfrom
faze-geek:Ellipsis

Conversation

@faze-geek

Copy link
Copy Markdown
Contributor

Fixes #2001

@certik certik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's good, thank you @faze-geek for the quick fix!

@certik
certik merged commit 97c61a6 into lcompilers:main Jun 25, 2023
@faze-geek
faze-geek deleted the Ellipsis branch June 25, 2023 16:10
@rebcabin

Copy link
Copy Markdown
Contributor

thanks @faze-geek !

@rebcabin

rebcabin commented Jun 25, 2023 •

Copy link
Copy Markdown
Contributor

Perhaps not quite done?

@dataclass
class MultiplicityNode:
    """foo"""
    ...  # doesn't work in LPython ; does work in CPython --- LPython treats as expression?
    pass # works
semantic error: Only doc strings allowed as expressions inside class
  --> /Users/brian/CLionProjects/lpython/lasr/LP-pycharm/lasr_parser.py:91:5
   |
91 |     ...  # doesn't work --- treated as expression?
   |     ^^^ 

@certik

certik commented Jun 25, 2023

Copy link
Copy Markdown
Contributor

I think there are different places in the code where ... and pass can appear, we just have to get them all. Go ahead and report this as another bug, so that we don't forget.

@faze-geek faze-geek mentioned this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unimplemented ... should print error, not throw

3 participants